Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate method argument in favor of inference_method #554

Merged
merged 3 commits into from
Aug 12, 2022

Conversation

aloctavodia
Copy link
Collaborator

Following discussion in #553

bambi/models.py Outdated Show resolved Hide resolved
@tomicapretto
Copy link
Collaborator

Apart from the small comment, looks good to me!

@codecov-commenter
Copy link

Codecov Report

Merging #554 (878d8c6) into main (236021f) will decrease coverage by 0.50%.
The diff coverage is 88.46%.

❗ Current head 878d8c6 differs from pull request most recent head a43ad64. Consider uploading reports for the commit a43ad64 to get more accurate results

@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   86.93%   86.42%   -0.51%     
==========================================
  Files          32       32              
  Lines        2655     2675      +20     
==========================================
+ Hits         2308     2312       +4     
- Misses        347      363      +16     
Impacted Files Coverage Δ
bambi/models.py 85.25% <71.42%> (-4.50%) ⬇️
bambi/backend/pymc.py 82.75% <80.00%> (+1.53%) ⬆️
bambi/tests/test_built_models.py 99.03% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aloctavodia aloctavodia merged commit 743e86f into bambinos:main Aug 12, 2022
@aloctavodia aloctavodia deleted the imethod branch August 12, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants