Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ordinal families #678

Merged
merged 10 commits into from
May 31, 2023
Merged

Add ordinal families #678

merged 10 commits into from
May 31, 2023

Conversation

tomicapretto
Copy link
Collaborator

@tomicapretto tomicapretto commented May 27, 2023

This PR adds two new families: "cumulative" and "sratio". These are directly inspired by their versions in brms. For more information about them see the excellent tutorial Ordinal Regression Models in Psychology: A Tutorial.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tomicapretto tomicapretto marked this pull request as ready for review May 31, 2023 22:24
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #678 (10b409c) into main (b83f545) will increase coverage by 0.64%.
The diff coverage is 97.23%.

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
+ Coverage   88.01%   88.65%   +0.64%     
==========================================
  Files          40       40              
  Lines        2678     2847     +169     
==========================================
+ Hits         2357     2524     +167     
- Misses        321      323       +2     
Impacted Files Coverage Δ
bambi/defaults/families.py 87.50% <ø> (ø)
bambi/families/likelihood.py 85.36% <ø> (ø)
bambi/priors/prior.py 86.11% <44.44%> (-13.89%) ⬇️
bambi/formula.py 94.73% <92.30%> (-1.82%) ⬇️
bambi/backend/model_components.py 100.00% <100.00%> (ø)
bambi/backend/terms.py 96.47% <100.00%> (ø)
bambi/backend/utils.py 90.62% <100.00%> (+0.96%) ⬆️
bambi/families/family.py 94.79% <100.00%> (+0.22%) ⬆️
bambi/families/multivariate.py 97.05% <100.00%> (+0.04%) ⬆️
bambi/families/univariate.py 97.61% <100.00%> (+1.81%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomicapretto tomicapretto changed the title [WIP] Add ordinal families Add ordinal families May 31, 2023
@tomicapretto tomicapretto merged commit d3b4f05 into bambinos:main May 31, 2023
4 checks passed
@tomicapretto tomicapretto deleted the ordinal branch May 31, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants