Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify how we handle dims #682

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

tomicapretto
Copy link
Collaborator

Closes #681 #651

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #682 (bb0ab38) into main (d3b4f05) will decrease coverage by 0.25%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   88.65%   88.41%   -0.25%     
==========================================
  Files          40       40              
  Lines        2848     2858      +10     
==========================================
+ Hits         2525     2527       +2     
- Misses        323      331       +8     
Impacted Files Coverage Δ
bambi/priors/scaler.py 96.70% <ø> (ø)
bambi/families/family.py 92.85% <60.00%> (-1.94%) ⬇️
bambi/families/univariate.py 96.12% <71.42%> (-1.50%) ⬇️
bambi/backend/model_components.py 100.00% <100.00%> (ø)
bambi/backend/terms.py 96.47% <100.00%> (ø)
bambi/model_components.py 88.88% <100.00%> (-0.93%) ⬇️
bambi/models.py 78.65% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomicapretto tomicapretto merged commit de7336b into bambinos:main Jun 9, 2023
4 checks passed
@tomicapretto tomicapretto deleted the fix_non_parent_alias branch June 9, 2023 02:21
GStechschulte pushed a commit to GStechschulte/bambi that referenced this pull request Jun 9, 2023
* Robustify how we handle dims

* Add clarification to function docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bambi is not handling aliases of non-parent parameters correctly.
2 participants