-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow predictions on new groups #693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #693 +/- ##
==========================================
+ Coverage 88.32% 88.77% +0.44%
==========================================
Files 40 40
Lines 2862 2976 +114
==========================================
+ Hits 2528 2642 +114
Misses 334 334
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GStechschulte
pushed a commit
to GStechschulte/bambi
that referenced
this pull request
Jun 29, 2023
This was referenced Sep 15, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model.predict()
gains a new argumentsample_new_groups
which determines if we want to allow for predictions on new groups. This is useful in the context of hierarchical modeling, where groups are assumed to be a sample from a larger group. With this new feature, we can get predictions for a new, unseen, group.Small example
Notice how the variability increases for the new group. Only a single resampling method is supported for now and it's equivalent to
sample_new_levels="uncertainty"
in brms.To Do
Closes #417