Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_model_covariates() utility function #801

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

tomicapretto
Copy link
Collaborator

This PR closes #797.

It returns those names available in Model.data, which is the data frame where covariates are taken from.

@tomicapretto
Copy link
Collaborator Author

I think the reason why CI failed is https://github.com/pymc-devs/pymc/releases/tag/v5.13.0 and pymc-devs/pymc#7047. I'm setting pymc<5.13.0 in our pyproject.toml. If CI passes I will merge. I think we need to resolve the issues created by the changes in PyMC in a different PR.

@tomicapretto tomicapretto merged commit 5c00663 into bambinos:main Apr 9, 2024
4 checks passed
@tomicapretto tomicapretto deleted the fix_covariates_detection branch April 9, 2024 15:25
@GStechschulte
Copy link
Collaborator

Thanks a lot @tomicapretto 👍🏼

GStechschulte pushed a commit to GStechschulte/bambi that referenced this pull request Apr 14, 2024
GStechschulte added a commit that referenced this pull request Apr 15, 2024
* add inference_methods class to obtain names of methods and kwargs

* re-run notebook

* update notebook to include new methods

* convienent methods for getting inference names and kwargs

* Fix `get_model_covariates()` utility function (#801)

* Support PyMC 5.13 and fix bayeux related issues (#803)

* run black to fix formatting

* add test to check for inference method names

* test get_kwargs method of InferenceMethods class

---------

Co-authored-by: Tomás Capretto <tomicapretto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non covariate variables being detected as covariates
2 participants