feat: performance optimization

bambu-group-03 · Nov 12, 2023 · 1483e7d · 1483e7d
1 parent 6cb62cd
commit 1483e7d
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 46 deletions.
diff --git a/src/api/snaps/types.ts b/src/api/snaps/types.ts
@@ -11,4 +11,5 @@ export type Snap = {
   has_shared: boolean;
   favs: number;
   num_replies: number;
+  profile_photo_url: string;
 };
diff --git a/src/screens/feed/card.tsx b/src/screens/feed/card.tsx
@@ -28,24 +28,6 @@ export const Card = ({ snap, client, onPress = () => {} }: Props) => {
     day: '2-digit',
   });
 
-  const [user, setUser] = useState<UserType>();
-
-  // Pido la cantidad de followers
-  useEffect(() => {
-    axios
-      .get(
-        'https://api-identity-socializer-luiscusihuaman.cloud.okteto.net/api/auth/users/' +
-          snap.author
-      )
-      .then((response) => {
-        console.log(response.data);
-        setUser(response.data);
-      })
-      .catch((error) => {
-        console.error(error);
-      });
-  }, [snap]);
-
   console.log(snap);
 
   return (
@@ -56,7 +38,7 @@ export const Card = ({ snap, client, onPress = () => {} }: Props) => {
             <Image
               className="inline-block h-10 w-10 rounded-full"
               source={{
-                uri: user?.profile_photo_id ? user?.profile_photo_id : '',
+                uri: snap.profile_photo_url,
               }}
             />
           </View>
@@ -89,7 +71,9 @@ export const Card = ({ snap, client, onPress = () => {} }: Props) => {
                   if (isRetweeted) {
                     interaction = '/unshare/';
                     method = 'DELETE';
-                    snap.shares--;
+                    if (snap.shares > 0) {
+                      snap.shares--;
+                    }
                   } else {
                     interaction = '/share/';
                     method = 'POST';
@@ -118,7 +102,9 @@ export const Card = ({ snap, client, onPress = () => {} }: Props) => {
                   if (isLiked) {
                     interaction = '/unlike/';
                     method = 'DELETE';
-                    snap.likes--;
+                    if (snap.likes > 0) {
+                      snap.likes--;
+                    }
                   } else {
                     interaction = '/like/';
                     method = 'POST';

diff --git a/src/screens/profile/my-snaps-view.tsx b/src/screens/profile/my-snaps-view.tsx
@@ -81,7 +81,7 @@ const MySnapsView = () => {
         data={data}
         renderItem={renderItem}
         keyExtractor={(_, index) => `item-${index}`}
-        // ListEmptyComponent={<EmptyList isLoading={isLoading} />}
+        ListEmptyComponent={<EmptyList isLoading={isLoading} />}
         onEndReached={handleEndReached}
         onEndReachedThreshold={0.1}
         refreshControl={

diff --git a/src/screens/profile/profile-screen.tsx b/src/screens/profile/profile-screen.tsx
@@ -48,30 +48,6 @@ const ProfileScreen = () => {
       });
   }, [userData]);
 
-  // Pido los snaps del usuario
-  // useEffect(() => {
-  //   const limit = 100;
-  //   const offset = 0;
-
-  //   axios
-  //     .get(
-  //       BASE_SNAP_URL +
-  //         userData?.id +
-  //         '/snaps?limit=' +
-  //         limit +
-  //         '&offset=' +
-  //         offset
-  //     )
-  //     .then((response) => {
-  //       console.log('Recibi de Snaps');
-  //       console.log(response.data);
-  //       setUserSnaps(response.data.snaps);
-  //     })
-  //     .catch((error) => {
-  //       console.error(error);
-  //     });
-  // }, [userData]);
-
   return (
     <>
       <FocusAwareStatusBar />