Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/profile view #71

Merged
merged 10 commits into from
Nov 11, 2023
Merged

Feat/profile view #71

merged 10 commits into from
Nov 11, 2023

Conversation

LuisParedes1
Copy link
Contributor

¿Qué hace esto?

Profile View

¿Por qué hiciste esto?

Feature

¿A quién/qué afecta esto?

End User

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

src/screens/profile/profile-view.tsx|17 col 21| Invalid Tailwind CSS classnames order
src/screens/profile/profile-view.tsx|21 col 13| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|21 col 19| Invalid Tailwind CSS classnames order
src/screens/profile/profile-view.tsx|22 col 15| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|22 col 21| Invalid Tailwind CSS classnames order
src/screens/profile/profile-view.tsx|23 col 17| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|24 col 19| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|25 col 21| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|25 col 27| Invalid Tailwind CSS classnames order
src/screens/profile/profile-view.tsx|29 col 21| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|31 col 30| Inline style: { color: '#0077cc', textDecorationLine: 'underline' }
src/screens/profile/profile-view.tsx|41 col 17| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|42 col 19| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|43 col 21| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|43 col 27| Invalid Tailwind CSS classnames order
src/screens/profile/profile-view.tsx|47 col 21| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|49 col 30| Inline style: { color: '#0077cc', textDecorationLine: 'underline' }
src/screens/profile/profile-view.tsx|61 col 11| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|61 col 17| Invalid Tailwind CSS classnames order
src/screens/profile/profile-view.tsx|62 col 13| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|62 col 19| Invalid Tailwind CSS classnames order
src/screens/profile/profile-view.tsx|65 col 13| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|65 col 19| Invalid Tailwind CSS classnames order
src/screens/profile/profile-view.tsx|66 col 15| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|71 col 11| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|71 col 17| Invalid Tailwind CSS classnames order
src/screens/profile/profile-view.tsx|72 col 13| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|73 col 15| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|74 col 17| 'React' must be in scope when using JSX
src/screens/profile/profile-view.tsx|74 col 23| Invalid Tailwind CSS classnames order

Comment on lines 1 to 6
import type { IconDefinition } from '@fortawesome/free-solid-svg-icons';
import { faFeed, faMessage, faSearch } from '@fortawesome/free-solid-svg-icons';
import { faFeed, faMessage, faPowerOff, faSearch } from '@fortawesome/free-solid-svg-icons';

import { Search } from '@/screens';
import { ProfileNavigator } from '@/screens/profile/profile-navigator';
import { ChatNavigator } from '@/screens/chat/chat-navigator';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <simple-import-sort/imports> reported by reviewdog 🐶
Run autofix to sort these imports!

Suggested change
import type { IconDefinition } from '@fortawesome/free-solid-svg-icons';
import { faFeed, faMessage, faSearch } from '@fortawesome/free-solid-svg-icons';
import { faFeed, faMessage, faPowerOff, faSearch } from '@fortawesome/free-solid-svg-icons';
import { Search } from '@/screens';
import { ProfileNavigator } from '@/screens/profile/profile-navigator';
import { ChatNavigator } from '@/screens/chat/chat-navigator';
import type { IconDefinition } from '@fortawesome/free-solid-svg-icons';
import { faFeed, faMessage, faPowerOff, faSearch } from '@fortawesome/free-solid-svg-icons';
import { Search } from '@/screens';
import { ChatNavigator } from '@/screens/chat/chat-navigator';
import { ProfileNavigator } from '@/screens/profile/profile-navigator';

@@ -1,7 +1,8 @@
import type { IconDefinition } from '@fortawesome/free-solid-svg-icons';
import { faFeed, faMessage, faSearch } from '@fortawesome/free-solid-svg-icons';
import { faFeed, faMessage, faPowerOff, faSearch } from '@fortawesome/free-solid-svg-icons';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·faFeed,·faMessage,·faPowerOff,·faSearch· with ⏎··faFeed,⏎··faMessage,⏎··faPowerOff,⏎··faSearch,⏎

Suggested change
import { faFeed, faMessage, faPowerOff, faSearch } from '@fortawesome/free-solid-svg-icons';
import {
faFeed,
faMessage,
faPowerOff,
faSearch,
} from '@fortawesome/free-solid-svg-icons';

component: ProfileNavigator, // React Profile component screen
label: 'ProfileNavigator',
icon: faPowerOff,
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,

Suggested change
}
},

Comment on lines +1 to +9
import { useNavigation } from '@react-navigation/native';
import React, { useState } from 'react';
import { FlatList } from 'react-native'; // Import FlatList

import type { Snap } from '@/api';
import { useSnaps } from '@/api';
import { getUserState } from '@/core';
import { EmptyList, FocusAwareStatusBar, Text, View } from '@/ui';
import axios from 'axios';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <simple-import-sort/imports> reported by reviewdog 🐶
Run autofix to sort these imports!

Suggested change
import { useNavigation } from '@react-navigation/native';
import React, { useState } from 'react';
import { FlatList } from 'react-native'; // Import FlatList
import type { Snap } from '@/api';
import { useSnaps } from '@/api';
import { getUserState } from '@/core';
import { EmptyList, FocusAwareStatusBar, Text, View } from '@/ui';
import axios from 'axios';
import { useNavigation } from '@react-navigation/native';
import axios from 'axios';
import React, { useState } from 'react';
import { FlatList } from 'react-native'; // Import FlatList
import type { Snap } from '@/api';
import { useSnaps } from '@/api';
import { getUserState } from '@/core';
import { EmptyList, FocusAwareStatusBar, Text, View } from '@/ui';

Comment on lines +6 to +7
import { useSnaps } from '@/api';
import { getUserState } from '@/core';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <unused-imports/no-unused-imports> reported by reviewdog 🐶
'useSnaps' is defined but never used.

Suggested change
import { useSnaps } from '@/api';
import { getUserState } from '@/core';
import { getUserState } from '@/core';

<View className="relative max-w-md mx-auto md:max-w-2xl min-w-0 break-words bg-white w-full mb-6 shadow-lg rounded-xl mt-3">
<View className="px-6">
<View className="flex flex-wrap justify-center">
<View className="w-full flex justify-center items-center text-center">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react/react-in-jsx-scope> reported by reviewdog 🐶
'React' must be in scope when using JSX

<View className="relative max-w-md mx-auto md:max-w-2xl min-w-0 break-words bg-white w-full mb-6 shadow-lg rounded-xl mt-3">
<View className="px-6">
<View className="flex flex-wrap justify-center">
<View className="w-full flex justify-center items-center text-center">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <tailwindcss/classnames-order> reported by reviewdog 🐶
Invalid Tailwind CSS classnames order

Suggested change
<View className="w-full flex justify-center items-center text-center">
<View className="flex w-full items-center justify-center text-center">

<View className="px-6">
<View className="flex flex-wrap justify-center">
<View className="w-full flex justify-center items-center text-center">
<View className="relative">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react/react-in-jsx-scope> reported by reviewdog 🐶
'React' must be in scope when using JSX

Comment on lines +12 to +15
<Image
source={user?.profile_photo_id}
className="order-1 h-32 w-32 rounded-full" // Adjusted size to h-32 and w-32
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react/react-in-jsx-scope> reported by reviewdog 🐶
'React' must be in scope when using JSX

className="order-1 h-32 w-32 rounded-full" // Adjusted size to h-32 and w-32
/>
</View>
<Text className="text-xl font-bold block tracking-wide text-slate-700 text-center">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react/react-in-jsx-scope> reported by reviewdog 🐶
'React' must be in scope when using JSX

@LuisParedes1 LuisParedes1 merged commit c842fa9 into main Nov 11, 2023
1 of 2 checks passed
@LuisParedes1 LuisParedes1 deleted the feat/profile_view branch November 11, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant