Added props for finer control over styles and animations #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
October 2, 2018 13:26
Nhacsam
reviewed
Jan 18, 2019
|
|
||
| |`headerContainerStyle`|`Object`|`undefined`|Optional styles to be passed to the container of the header component| | ||
| |`disableHeaderGrow`|`boolean`|`undefined`|Disable to grow effect on the header| | ||
| |`disableOverlay`|`boolean`|`undefined`|Disable the image overlay| |
There was a problem hiding this comment.
I removed it to use maxOverlayOpacity={0] instead
Nhacsam
reviewed
Jan 18, 2019
Nhacsam
reviewed
Jan 18, 2019
| ref={ref => (this.scrollViewRef = ref)} | ||
| ref={ref => { | ||
| if (getScrollViewRef) { | ||
| getScrollViewRef(ref); |
There was a problem hiding this comment.
What is the usecase for that?
There was a problem hiding this comment.
I was unable to access the ref, can't remember the specific use case as it was a while ago
|
Thank a lot for your contribution. I made some changes before merging here but your commits are now in the master branch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to achieve the styles I wanted, so I added the following props to the scroll view:
headerContainerStyle- style object that gets passed to theAnimated.Viewheader container (useful for shadow overlaying scrolling container).disableHeaderGrow- disables the scale transform animation on the headerdisableOverlay- prevents overlay from rendering (useful for when setting totransparentisn't enough)