Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No matching function for call to 'transformImage' (#342) #350

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

chj-damon
Copy link
Contributor

fix error when archive app in xcode

fix error when archive app in xcode
@robingullo
Copy link

Thank you for your contribution. We don't want to modify the signature of the methods, since they need to be compatible with the architecture's codegen. Could you try instead in line 53 of ImageResizer.mm:

-            NSDictionary * response =  transformImage(image, uri, [rotation integerValue], newSize, fullPath, format, (int)quality, keepMeta, @{@"mode": mode, @"onlyScaleDown": [NSNumber numberWithBool:onlyScaleDown]});
+            NSDictionary * response =  transformImage(image, uri, [rotation integerValue], newSize, fullPath, format, (int)quality, [keepMeta boolValue], @{@"mode": mode, @"onlyScaleDown": [NSNumber numberWithBool:onlyScaleDown]});

@chj-damon
Copy link
Contributor Author

@robingullo I tried this solution in xcode 13.4.1 and it works.

also, I tried not change any code and it also works in xcode 14.2/m2 chip. I don't why

@chj-damon
Copy link
Contributor Author

updated.

@taboulot taboulot changed the title fix: #342 fix: No matching function for call to 'transformImage' (#342) Feb 15, 2023
@taboulot
Copy link
Contributor

I have Xcode 14.0.1 and no error occurred without the fix but I have a warning.

I think some configurations changed in the Xcode compiler during migration from 13.x -> 14.x with the consequence that this error in version 13 was only a warning in version 14.

Anyway, this PR fix a syntax error, improve the code & fix #342.

@taboulot taboulot merged commit 4b3bc68 into bamlab:master Feb 15, 2023
@chj-damon chj-damon deleted the patch-1 branch February 16, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants