Issue 328 ios fix image loading using uri or path #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use RCTConvert & RCTUmageLoader in order to load images correctly with path and uri
taboulot
force-pushed
the
issue-328-ios-fix-image-loading-using-uri-or-path
branch
from
de607fc
to
8d707ac
Compare
This was referenced Aug 21, 2023
Closed
jcalixte
requested changes
Aug 22, 2023
README.md
Outdated
| @@ -90,6 +95,9 @@ The promise resolves with an object containing: `path`, `uri`, `name`, `size` (b | |||
| | keepMeta | If `true`, will attempt to preserve all file metadata/exif info, except the orientation value since the resizing also does rotation correction to the original image. Defaults to `false`, which means all metadata is lost. Note: This can only be `true` for `JPEG` images which are loaded from the file system (not Web). | | |||
| | options.mode | Similar to [react-native Image's resizeMode](https://reactnative.dev/docs/image#resizemode): either `contain` (the default), `cover`, or `stretch`. `contain` will fit the image within `width` and `height`, preserving its ratio. `cover` preserves the aspect ratio, and makes sure the image is at least `width` wide or `height` tall. `stretch` will resize the image to exactly `width` and `height`. | | |||
| | options.onlyScaleDown | If `true`, will never enlarge the image, and will only make it smaller. | | |||
| # Limitations | |||
|
|
|||
| - If you are using `@react-native-camera-roll/camera-roll` **with new architecture enabled this library is not going to work**. If you try to display an image with the `uri` of the library using `<Image />` you are going to have the following error: `No suitable image URL loader found for ph://...`. This error come from the ReactNative `ImageLoader`, which is the one we are currently using. Help/PR for solving this are welcome. | |||
There was a problem hiding this comment.
At the moment using react-native-image-picker.
There was a problem hiding this comment.
inside @react-native-camera-roll/camera-roll you have a util method that permit to load ph images and convert them into local images
jcalixte
approved these changes
Aug 22, 2023
taboulot
force-pushed
the
issue-328-ios-fix-image-loading-using-uri-or-path
branch
from
8d707ac
to
78d4350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This fix the issue #328.
iOS was only accepted
uriusing schemefile://. This is a regression from version <3.x.x.Solution
The solution was to use the React-Native url converter & image loader in order to handle both
path&uri(with several protocol/scheme).Test
This PR also add several image sources in the example application using:
react-native-image-picker;react-native-vision-camera;@react-native-camera-roll/camera-roll;http://.....);