Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated method for RN 0.47 compat #92

Closed
wants to merge 1 commit into from

Conversation

forki
Copy link

@forki forki commented Jul 28, 2017

The component doesn't compile in RN 0.47-rc5 - discussion at facebook/react-native#15232

@sibelius
Copy link
Contributor

sibelius commented Aug 2, 2017

I think it is better to just remove the @ override

much like this one https://github.com/idehub/react-native-google-analytics-bridge/pull/156/files

@bamlab can we get this in?

@4ian
Copy link
Contributor

4ian commented Aug 2, 2017

Merged the fix that removes the @OverRide annotation. Can you confirm this is working on both 0.47 and pre-0.47 versions of React Native?

@pdavid0
Copy link

pdavid0 commented Aug 17, 2017

Fresh install

>yarn add react-native-image-resizer
success Saved 1 new dependencies.
├─ react-native-image-resizer@0.1.1

@Override is still present in ImageResizerPackage.java

Works with master branch.

>yarn add github:bamlab/react-native-image-resizer

@4ian
Copy link
Contributor

4ian commented Aug 17, 2017

Yep, I'll publish a new release today to fix this issue! Thanks for confirming that things work with master branch :)

@4ian
Copy link
Contributor

4ian commented Aug 17, 2017

Done! :) Closing this issue now as problem is solved. 😄

@4ian 4ian closed this Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants