Skip to content

Commit

Permalink
Remove Python 3.7 from CI-runs on MacOS
Browse files Browse the repository at this point in the history
Python 3.7 has been officially unsupported for over half a year now, and
github's CI doesn't seem to support it on MacOS anymore. We're still
going to do Python 3.7 CI-runs on windows and linux for now because they
still seem to work, and the python community is notoriously slow to
retire unsupported python versions.
  • Loading branch information
robamler committed Apr 28, 2024
1 parent 06c21ad commit 34152c9
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 5 deletions.
20 changes: 15 additions & 5 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ jobs:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
os: [ubuntu-latest, macos-latest, windows-latest]

exclude:
- os: macos-latest
python-version: "3.7"
steps:
- name: Checkout
uses: actions/checkout@v1
Expand Down Expand Up @@ -241,6 +243,7 @@ jobs:
- name: Set up Python 3.7
id: setup-python-3-7
uses: actions/setup-python@v5
if: matrix.os != 'macos-latest'
with:
python-version: 3.7

Expand Down Expand Up @@ -284,14 +287,21 @@ jobs:
ls -l LICENSE*
wc -l LICENSE*
- name: Build wheels (unix)
if: matrix.os != 'windows-latest'
- name: Build wheels (ubuntu)
if: matrix.os == 'ubuntu-latest'
uses: messense/maturin-action@v1
with:
command: build
manylinux: 2014
args: --release --strip --features pybindings -i python3.7 python3.8 python3.9 python3.10 python3.11 python3.12

- name: Build wheels (macos)
if: matrix.os == 'macos-latest'
uses: messense/maturin-action@v1
with:
command: build
args: --release --strip --features pybindings -i python3.8 python3.9 python3.10 python3.11 python3.12

- name: Build wheels (windows)
if: matrix.os == 'windows-latest'
uses: messense/maturin-action@v1
Expand All @@ -305,14 +315,14 @@ jobs:
with:
target: aarch64-apple-darwin
command: build
args: --release --strip --features pybindings -i python3.7 python3.8 python3.9 python3.10 python3.11 python3.12
args: --release --strip --features pybindings -i python3.8 python3.9 python3.10 python3.11 python3.12

- name: Build universal2 wheels
if: matrix.os == 'macos-latest'
uses: messense/maturin-action@v1
with:
command: build
args: --release --strip --features pybindings --universal2 -i python3.7 python3.8 python3.9 python3.10 python3.11 python3.12
args: --release --strip --features pybindings --universal2 -i python3.8 python3.9 python3.10 python3.11 python3.12

- name: List wheels
shell: bash
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ jobs:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
os: [ubuntu-latest, macos-latest, windows-latest]
exclude:
- os: macos-latest
python-version: "3.7"

steps:
- name: Checkout
Expand Down

0 comments on commit 34152c9

Please sign in to comment.