Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with League/Flysystem #383

Closed
a3gz opened this issue Dec 7, 2020 · 1 comment
Closed

Incompatibility with League/Flysystem #383

a3gz opened this issue Dec 7, 2020 · 1 comment

Comments

@a3gz
Copy link

a3gz commented Dec 7, 2020

Hello, I noticed today that there's an incompatibility with PHPloy and the latest version of League/Flysystem.

The following are lines 5 to 7 of src/Connection.php

5 use League\Flysystem\Adapter\Ftp as FtpAdapter;
6 use League\Flysystem\Filesystem;
7 use League\Flysystem\Sftp\SftpAdapter as SftpAdapter;

PHPloy version 4.9.1 will require Flysystem 2.0.0 where the files referenced on lines 5 and 7 don't exist anymore. They have at least changed locations. I say "at least" because I don't know if they have also changed behavior.
In any case, my pipleline started to crash today due to this.

I believe that the issue may be the change in requiring Flysystem ^1.0 to >=1.0.0. If I'm not mistaken, by requiring >=1.0.0 we also need to specify the higher limit as in >=1.0.0 <2.0 to prevent installing versions that carry breaking changes.

I could solve the issue by specifically using PHPloy v 4.8.5.

@a3gz a3gz closed this as completed Dec 7, 2020
@a3gz
Copy link
Author

a3gz commented Dec 7, 2020

I'm so dumb! There was already a pull request pending to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant