Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with rollback command #50

Closed
SimonEast opened this issue Aug 15, 2014 · 2 comments
Closed

Issues with rollback command #50

SimonEast opened this issue Aug 15, 2014 · 2 comments
Labels
Milestone

Comments

@SimonEast
Copy link
Contributor

There's currently two issues with the --rollback command.

  1. It doesn't handle submodules correctly. See source code note here.
  2. It returns the working copy to the master branch, which may not be what the user intended. See source code note here.

I'm unlikely to have time to fix these any time soon unfortunately, but if anyone else wants to have a go, feel free. 👍

@SimonEast SimonEast changed the title Rollbacks don't handle submodules correctly Rollback command pretty buggy Aug 15, 2014
@banago banago changed the title Rollback command pretty buggy Issues with rollback command Aug 15, 2014
@banago banago modified the milestone: Future Feb 9, 2015
@banago banago modified the milestones: PHPloy v3, Future, PHPloy v4 Feb 24, 2015
@banago banago mentioned this issue Feb 24, 2015
@banago banago added discussion and removed bug labels Feb 25, 2015
@banago
Copy link
Owner

banago commented Feb 25, 2015

@SimonEast this issue of returning to master after rollback is now fixed by this super-awesome contrbutor @GuidoHendriks.

For the submodule handle, I don't see how it can be implemented - I'm out of ideas. What's on your mind?

@banago banago modified the milestones: Future, PHPloy 4 Mar 15, 2016
@banago banago added bug and removed enhancement labels Jan 26, 2017
@banago
Copy link
Owner

banago commented Feb 24, 2018

Submodule rollback won't work at this time.

@banago banago closed this as completed Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants