Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/upgrade ipywidgets version #54

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Conversation

marcofavoritobi
Copy link
Contributor

@marcofavoritobi marcofavoritobi commented Mar 27, 2023

Proposed changes

One of the changes in this new version is the removal of the dependency
ipykernel, which we would require to add it as explicit dependency.

Due to potential breaking changes, we fix its maximum version below 8.0.5.

Fixes

n/a

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Merging #54 (6b225e0) into main (c0e2e68) will increase coverage by 0.06%.
The diff coverage is 98.90%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   96.86%   96.92%   +0.06%     
==========================================
  Files          31       34       +3     
  Lines        1499     1563      +64     
==========================================
+ Hits         1452     1515      +63     
- Misses         47       48       +1     
Impacted Files Coverage Δ
black_it/calibrator.py 97.00% <97.50%> (-0.30%) ⬇️
black_it/schedulers/__init__.py 100.00% <100.00%> (ø)
black_it/schedulers/base.py 100.00% <100.00%> (ø)
black_it/schedulers/round_robin.py 100.00% <100.00%> (ø)
black_it/utils/json_pandas_checkpointing.py 100.00% <100.00%> (ø)

This change is required by the release of ipywidgets at version 8.0.5.

  jupyter-widgets/ipywidgets#3533

One of the changes in this new version is the removal of the dependency
ipykernel, which we would require to add it as explicit dependency.

Due to potential breaking changes, we fix its maximum version below 8.0.5.
@marcofavoritobi marcofavoritobi merged commit 662a549 into main Mar 27, 2023
@marcofavoritobi marcofavoritobi deleted the chore/upgrade-ipywidgets branch March 27, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants