Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior for target tokens #585

Open
NIXBNT opened this issue Apr 30, 2024 · 0 comments
Open

Unexpected behavior for target tokens #585

NIXBNT opened this issue Apr 30, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@NIXBNT
Copy link
Collaborator

NIXBNT commented Apr 30, 2024

Bug Description

Specifying only the wrapped token address in the target tokens excludes native tokens strategies on Carbon even though they would logically be supported by this flow.
Since the native token is not required to be specified in the __flashloan_tokens__ then as a logic consistency it shouldn't need to be specified in the target_tokens

Severity (High/Medium/Low)

Low

Steps to Reproduce

WANTED:
python main.py --blockchain=ethereum --backdate_pools=False --arb_mode=triangle --exchanges=carbon_v1,uniswap_v3 --flashloan_tokens=0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2,0x514910771AF9Ca656af840dff83E8264EcF986CA --target_tokens=0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2,0x514910771AF9Ca656af840dff83E8264EcF986CA,0x8E870D67F660D95d5be530380D0eC0bd388289E1 --alchemy_max_block_fetch=200 --default_min_profit_gas_token=0.0001 --read_only=False --loglevel=DEBUG --randomizer=3 --reorg_delay=0 --polling_interval=0 --rpc_url=https://virtual.mainnet.rpc.tenderly.co/ca5f1233-86f6-420f-9915-0f28026697a3

CURRENT REQUIREMENT:
python main.py --blockchain=ethereum --backdate_pools=False --arb_mode=triangle --exchanges=carbon_v1,uniswap_v3 --flashloan_tokens=0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2,0x514910771AF9Ca656af840dff83E8264EcF986CA --target_tokens=0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE,0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2,0x514910771AF9Ca656af840dff83E8264EcF986CA,0x8E870D67F660D95d5be530380D0eC0bd388289E1 --alchemy_max_block_fetch=200 --default_min_profit_gas_token=0.0001 --read_only=False --loglevel=DEBUG --randomizer=3 --reorg_delay=0 --polling_interval=0 --rpc_url=https://virtual.mainnet.rpc.tenderly.co/ca5f1233-86f6-420f-9915-0f28026697a3

Expected Behavior

No requirement specify native token in the target_tokens

Actual Behavior

Native token in required to be specified in the target_tokens else native containing strategies on Carbon would be skipped

Impact Analysis (to be filled by contributors)

  • Automated Tests: Are there existing tests covering this? Do we need new tests?
  • Risks: Potential areas affected by this bug and its probable fix
  • Performance: Is this bug affecting performance?
  • Monitoring: Does this affect any current monitoring? Any new alerts needed?
  • Logging: Any changes required in logging?
  • Documentation: Updates needed in documentation?
@NIXBNT NIXBNT added the bug Something isn't working label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants