Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidly pools updated from events dont get "pool_type" #631

Open
NIXBNT opened this issue May 8, 2024 · 0 comments
Open

Solidly pools updated from events dont get "pool_type" #631

NIXBNT opened this issue May 8, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@NIXBNT
Copy link
Collaborator

NIXBNT commented May 8, 2024

Bug Description

Solidly pools require a designation of "stable" or "volatile" as their pool_type in order to be processed (as it stands only volatile solidly pools are supported by the bot).
When solidly pools are updated from event data, i.e. the pool is not in the static pool data but only in the solidly_v2_event_mappings, the "pool_type" field is not being populated and so the downstream tag "is_stable" is populated with nan. This breaks at the build curves step since only "volatile" is a suitable designation.
[bot.get_curves] SolidlyV2StablePoolsNotSupported: exchange aerodrome_v2

I was able to add this line to get the pool data to populate and thus arbs to work - however this is not an appropriate solution
image

Severity (High/Medium/Low)

High. Solidly pools not in the static pool data may not populate correctly. i.e. new solidly pools not supported

Steps to Reproduce

put loglevel=DEBUG on

Expected Behavior

Solidly curves should build properly so that they can be arbed

Actual Behavior

Solidly curves breaking when they go to be built

Impact Analysis (to be filled by contributors)

  • Automated Tests: Are there existing tests covering this? Do we need new tests?
  • Risks: Potential areas affected by this bug and its probable fix
  • Performance: Is this bug affecting performance?
  • Monitoring: Does this affect any current monitoring? Any new alerts needed?
  • Logging: Any changes required in logging?
  • Documentation: Updates needed in documentation?
@NIXBNT NIXBNT added the bug Something isn't working label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants