Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website setup #455

Closed
wants to merge 55 commits into from
Closed

Website setup #455

wants to merge 55 commits into from

Conversation

kalidiagne
Copy link
Collaborator

Description

Bandada website setup & structure

Related Issue

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 9:58am

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! @kalidiagne thank you very much. Great work. It looks really nice.

I left one comment.

Is it ok to remove the package-lock.json file, because we are using yarn?

There are some issues related to eslint and prettier. We can take a look later.

apps/website/package.json Outdated Show resolved Hide resolved
@0xjei
Copy link
Collaborator

0xjei commented May 22, 2024

@kalidiagne thanks for all the updates.

The page is present, what problem are you facing?

If I go to the build page (clicking on Build in the header): http://localhost:3003/build, I see the 404 error page.

I found the same bug - thx for reporting @vplasencia

@kalidiagne
Copy link
Collaborator Author

kalidiagne commented Jun 2, 2024

@kalidiagne thanks for all the updates.

The page is present, what problem are you facing?

If I go to the build page (clicking on Build in the header): http://localhost:3003/build, I see the 404 error page.

oh, this is super odd, can you please try again?
I do not have an error on that page

cc: @0xjei

Screenshot 2024-06-02 at 18 50 29

@kalidiagne
Copy link
Collaborator Author

kalidiagne commented Jun 2, 2024

amazing, the website looks awesome - thank you so much @kalidiagne for your hard work. I'd like to leave a couple of comments / feedbacks:

  • Projects built with Bandada section seems to be not left-start aligned, resulting in some left margin (same happening on mobile).

Screenshot from 2024-05-22 15-21-58

  • Join the Bandada community section with the Discord button. Is this necessary since we have another link to Discord on the footer?
  • The navbar contains Documentation and Github link. Should we open these in a new window as we do when pressing the Lunch App button?
  • I have noticed that most text is not centered when on mobile.

Screenshot from 2024-05-22 15-25-51 Screenshot from 2024-05-22 15-25-55

Thank you for the feedback, following the response for every point

The navbar contains Documentation and Github link. Should we open these in a new window as we do when pressing the Lunch App button?
Fixed

I have noticed that most text is not centered when on mobile.
The actual mobile version and the screen you provide are matching with the design, only the section titles are centred, here is Figma ref: https://www.figma.com/design/8WLkTos9OQPp3MWx5w2gCJ/Bandada-Website?node-id=134-2493&t=VxvDRvT4zLWMd5wC-0

Join the Bandada community section with the Discord button. Is this necessary since we have another link to Discord on the footer?
For me, it's fine to remove it, I will also double-check with Mary

Projects built with Bandada section seems to be not left-start aligned, resulting in some left margin (same happening on mobile).
Will get back to you with this, thk!

@vplasencia
Copy link
Member

@kalidiagne thanks for all the updates.

The page is present, what problem are you facing?

If I go to the build page (clicking on Build in the header): http://localhost:3003/build, I see the 404 error page.

oh, this is super odd, can you please try again? I do not have an error on that page

cc: @0xjei

Screenshot 2024-06-02 at 18 50 29

Hey @kalidiagne! Interesting. I tried to go to the build page again and I still see 404: Page not found. Could it be related to a missing folder called build in the app folder?

@kalidiagne
Copy link
Collaborator Author

@kalidiagne thanks for all the updates.

The page is present, what problem are you facing?

If I go to the build page (clicking on Build in the header): http://localhost:3003/build, I see the 404 error page.

oh, this is super odd, can you please try again? I do not have an error on that page
cc: @0xjei
Screenshot 2024-06-02 at 18 50 29

Hey @kalidiagne! Interesting. I tried to go to the build page again and I still see 404: Page not found. Could it be related to a missing folder called build in the app folder?

Ah i see, i just updated the URL path name /build-with-bandada

Copy link
Collaborator

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now, tysm for the updates!

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kalidiagne thank you very much for the great work. Just left two comments. I think after those comments, everything is ready. Thank you very much 🙏

apps/website/components/cards/Card.tsx Outdated Show resolved Hide resolved
apps/website/common/settings.ts Outdated Show resolved Hide resolved
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 💯

@vplasencia vplasencia changed the base branch from dev to main June 7, 2024 10:01
@vplasencia vplasencia changed the base branch from main to dev June 7, 2024 10:02
@vplasencia vplasencia changed the base branch from dev to main June 7, 2024 10:02
@vplasencia vplasencia changed the base branch from main to dev June 7, 2024 10:02
@vplasencia vplasencia mentioned this pull request Jun 7, 2024
7 tasks
@vplasencia vplasencia changed the base branch from dev to main June 7, 2024 12:09
@vplasencia vplasencia changed the base branch from main to dev June 7, 2024 12:13
@kalidiagne kalidiagne mentioned this pull request Jun 7, 2024
2 tasks
@kalidiagne
Copy link
Collaborator Author

closing for #523

@kalidiagne kalidiagne closed this Jun 7, 2024
@vplasencia vplasencia deleted the website-setup branch June 7, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants