Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

scan: implement top part of validatorindexpage (mobile) #2294

Merged
merged 9 commits into from
Jul 24, 2020

Conversation

tansawit
Copy link
Contributor

@tansawit tansawit commented Jul 22, 2020

Fixed: #2265

Implementation details

Implement top part of ValidatorIndexPage mobile version

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

If this PR doesn't need to be merged into v1.0.6 please remove this option:

  • The pull request has been cherry-picked to rc/1.0.6

@render
Copy link

render bot commented Jul 22, 2020

@tansawit tansawit changed the title scan: implement top part of validatorindexpagemobile scan: implement top part of validatorindexpage (mobile) Jul 22, 2020
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix detail style also.
image

scan/src/pages/ValidatorIndexPage.re Outdated Show resolved Hide resolved
@tansawit tansawit requested a review from evilpeach July 23, 2020 08:10
scan/src/pages/ValidatorIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/ValidatorIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/ValidatorIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/ValidatorIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/ValidatorIndexPage.re Outdated Show resolved Hide resolved
@evilpeach evilpeach merged commit d23c7a8 into master Jul 24, 2020
@evilpeach evilpeach deleted the 2265-validator-index-top-part-mobile branch July 24, 2020 04:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator Index Page (Top Part) (mobile)
3 participants