Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

chain: Update json key name of request and response packets #2297

Merged
merged 3 commits into from
Jul 23, 2020

Conversation

sorawit
Copy link
Member

@sorawit sorawit commented Jul 23, 2020

Implementation details

This PR changes JSON key name of RequestPacketData and ResponsePacketData to underscore_case to make it consistent with other JSON representations.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

If this PR doesn't need to be merged into v1.0.6 please remove this option:

  • The pull request has been cherry-picked to rc/1.0.6

@render
Copy link

render bot commented Jul 23, 2020

@Benzbeeb Benzbeeb merged commit 59f6cef into master Jul 23, 2020
@Benzbeeb Benzbeeb deleted the update-json-packet branch July 23, 2020 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants