This repository has been archived by the owner on Nov 16, 2022. It is now read-only.
Scan: Implemented the txIndexPage's mobile layout #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://d3n-scan-pr-2310.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-bse2kpgl1r120j4eteu0. |
pzshine
changed the title
evilpeach
suggested changes
Jul 25, 2020
evilpeach
suggested changes
Jul 25, 2020
sorawit
reviewed
Jul 25, 2020
| @@ -1052,6 +1051,7 @@ let make = (~messages: list(TxSub.Msg.t)) => { | |||
| {messages | |||
| ->Belt.List.mapWithIndex((index, msg) => { | |||
| let theme = msg |> TxSub.Msg.getBadgeTheme; | |||
| //TODO: Change index to be uniqe something | |||
| type t = | ||
| | Address(Address.t, int) | ||
| | Address(Address.t, int, bool) |
There was a problem hiding this comment.
Maybe it's worth having a variant type for this. Can even be
Address(Address.t, int, [ `account | `validator ]). Or at least we can add a comment explaining the meaning of the boolean. Up to you guys.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #2304
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)