Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Improve how to pass the account type value and fix the typo #2315

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Jul 26, 2020

Fixed: #2314

Implementation details

  • Improved isValidator on AddressRender.re to prevent the miscommunication in the future.
  • Fixed typo on the comment.
  • Patched the new change on all files which were using the AddressRender component.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • [] The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested review from prin-r and evilpeach July 26, 2020 11:15
@render
Copy link

render bot commented Jul 26, 2020

Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sorawit Please go through.

Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@evilpeach evilpeach merged commit 0b96c62 into master Jul 27, 2020
@evilpeach evilpeach deleted the improve-the-code branch July 27, 2020 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change isValidator from boolean to variant in AddressRender.re
3 participants