Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Fix all bugs on mobile screen #2342

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Scan: Fix all bugs on mobile screen #2342

merged 4 commits into from
Jul 30, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Jul 30, 2020

Implementation details

  • Added background when the mobile menu is opened.
  • Removed the extra space on the mobile screen.
  • Fixed N/A state on validator homepage
  • Improved the layout on validator index (top part)

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach July 30, 2020 11:20
@render
Copy link

render bot commented Jul 30, 2020

scan/src/App.re Outdated Show resolved Hide resolved
@pzshine pzshine merged commit e96b9cc into master Jul 30, 2020
@pzshine pzshine deleted the improve-mobile-bug branch July 30, 2020 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants