Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

owasm: Add NaN canonicalization flag during initialization #2359

Merged
merged 4 commits into from
Aug 3, 2020

Conversation

sorawit
Copy link
Member

@sorawit sorawit commented Aug 1, 2020

Implementation details

This PR adds NaN canonicalization flag to ensure oracle script executions are deterministic across all platforms. See Wasmer#1303 for the feature.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@sorawit sorawit requested review from Benzbeeb and taobun August 1, 2020 06:17
@render
Copy link

render bot commented Aug 1, 2020

@sorawit sorawit force-pushed the wasmer-nan-canonicalization branch 2 times, most recently from ce3dae5 to 37d0b62 Compare August 1, 2020 06:31
@sorawit sorawit force-pushed the wasmer-nan-canonicalization branch from 37d0b62 to abfe7cb Compare August 1, 2020 06:35
@taobun taobun merged commit 139846e into master Aug 3, 2020
@taobun taobun deleted the wasmer-nan-canonicalization branch August 3, 2020 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants