Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Implementation of allow free report transaction #2387

Merged
merged 17 commits into from
Aug 21, 2020
Merged

Conversation

Benzbeeb
Copy link
Contributor

@Benzbeeb Benzbeeb commented Aug 5, 2020

Fixed: #2372
Fixed: #2370

Implementation details

Implement AnteHandle for NewMempoolFeeDecorator to allow report gas fee

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@Benzbeeb Benzbeeb requested review from sorawit and taobun August 5, 2020 06:57
@render
Copy link

render bot commented Aug 5, 2020

@Benzbeeb Benzbeeb changed the title Allow report gas fee Implementation of allow free report transaction Aug 5, 2020
chain/x/ante/ante.go Outdated Show resolved Hide resolved
chain/x/ante/ante.go Outdated Show resolved Hide resolved
chain/x/ante/ante.go Outdated Show resolved Hide resolved
chain/app/app.go Outdated Show resolved Hide resolved
chain/emitter/app.go Outdated Show resolved Hide resolved
chain/x/oracle/ante/ante.go Outdated Show resolved Hide resolved
@taobun taobun requested a review from sorawit August 12, 2020 13:45
Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just some minor comment change

chain/x/oracle/ante/ante.go Outdated Show resolved Hide resolved
@sorawit sorawit merged commit 0adef62 into master Aug 21, 2020
@sorawit sorawit deleted the allow-report-gas-fee branch August 21, 2020 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants