Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

pyobi: improve code structure, add PyObiBool and add more tests #2410

Merged
merged 11 commits into from
Aug 20, 2020

Conversation

prin-r
Copy link
Member

@prin-r prin-r commented Aug 7, 2020

Implementation details

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@render
Copy link

render bot commented Aug 7, 2020

@prin-r prin-r changed the title pyobi: add more feature and testcase pyobi: improve code structure, add PyObiBool and add more tests Aug 7, 2020
@prin-r prin-r requested review from sorawit and taobun August 7, 2020 09:30
@prin-r prin-r force-pushed the add-feature-pyobi-and-testcase branch from 8939731 to 0a21a98 Compare August 12, 2020 12:10
@prin-r prin-r requested a review from taobun August 12, 2020 12:11
@prin-r prin-r force-pushed the add-feature-pyobi-and-testcase branch from 0a21a98 to 97765d8 Compare August 18, 2020 03:57
obi/pyobi/pyobi/pyobi.py Outdated Show resolved Hide resolved
obi/pyobi/pyobi/pyobi.py Outdated Show resolved Hide resolved
obi/pyobi/pyobi/pyobi.py Outdated Show resolved Hide resolved
@prin-r prin-r requested review from sorawit and taobun August 20, 2020 04:42
@prin-r prin-r merged commit dbebc4b into master Aug 20, 2020
@prin-r prin-r deleted the add-feature-pyobi-and-testcase branch August 20, 2020 06:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants