Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: change exit_code, external_id from int to string #2456

Merged
merged 4 commits into from
Aug 16, 2020

Conversation

evilpeach
Copy link
Contributor

@evilpeach evilpeach commented Aug 11, 2020

Note

Please wait until the CBD has changed the exit_code type.

Implementation details

  • Change exit_code and external_id from int to string

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@render
Copy link

render bot commented Aug 11, 2020

@taobun taobun changed the title Scan: change exit_code, externail_id from int to string Scan: change exit_code, external_id from int to string Aug 13, 2020
@evilpeach evilpeach requested a review from pzshine August 16, 2020 08:11
Copy link
Member

@pzshine pzshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evilpeach evilpeach merged commit 2f0a0e9 into master Aug 16, 2020
@evilpeach evilpeach deleted the fix-exitcode-externalid branch August 16, 2020 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants