Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Implemented bottom part of DatasourceIndex page #2461

Merged
merged 7 commits into from
Aug 13, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Aug 12, 2020

Fixed: #2413 , #2414 , #2415

Implementation details

  • Implemented all tabs on Datasource index page:
    • Requests Tab
    • Code Tab
    • Test Execution Tab
  • Improved the components:
    • New ProgressBar.Modern component
    • Added marginBottom prop to Heading and Row.Grid components
    • New CopyButton(code copying)
    • New btn in CssHelper

Note

  • When there is no request, now I'm using noTransaction image(it will be replaced when we get a new image).

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach August 12, 2020 18:12
@render
Copy link

render bot commented Aug 12, 2020

Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's set the default tab to Request. You can do it in Route.re.
  2. On the iPhone, I cannot find Copy Code Button.

scan/src/reusable/Text.re Show resolved Hide resolved
scan/src/reusable/MobileCard.re Outdated Show resolved Hide resolved
scan/src/reusable/MobileCard.re Outdated Show resolved Hide resolved
scan/src/reusable/InfoMobileCard.re Outdated Show resolved Hide resolved
scan/src/reusable/InfoMobileCard.re Outdated Show resolved Hide resolved
scan/src/components/ProgressBar.re Outdated Show resolved Hide resolved
scan/src/components/buttons/CopyButton.re Outdated Show resolved Hide resolved
scan/src/components/data-source/DataSourceRequestTable.re Outdated Show resolved Hide resolved
@pzshine pzshine requested a review from evilpeach August 13, 2020 06:22
@pzshine pzshine force-pushed the bottom-port-datasource-index branch from 70adbce to 83019ea Compare August 13, 2020 07:41
@pzshine pzshine merged commit b16dc65 into master Aug 13, 2020
@pzshine pzshine deleted the bottom-port-datasource-index branch August 13, 2020 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp GuanYu - Implement Datasources Index (Request Tabs)
2 participants