Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Implemented OWASM code tab for OC index page, improved some components #2473

Merged
merged 3 commits into from
Aug 13, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Aug 13, 2020

Fixed: #2422

Implementation details

  • Implemented OWASM code tab
  • Fixed DataSource Copy position on mobile
  • Improved some components:
    • Copy.Code component
    • Be able to copy string instead of only Js.Buffer type
  • CToolTip component
    • Be able to adjust position on mobile(just added BottomLeft and BottomRight for now)

Note: In order to Ctooltip, it can be improved later.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach August 13, 2020 16:05
@render
Copy link

render bot commented Aug 13, 2020

@pzshine pzshine requested a review from evilpeach August 13, 2020 16:59
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pzshine pzshine merged commit c3fc052 into master Aug 13, 2020
@pzshine pzshine deleted the bottom-part-oracle-script-index branch August 13, 2020 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp GuanYu - Implement Owasm Code (OS Index)
2 participants