Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Implemented bridge code tab for OC index page. #2474

Merged
merged 5 commits into from
Aug 17, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Aug 14, 2020

Fixed: #2423

Implementation details

  • Implemented Bridge Code Tab for Oraclescripts index page
  • Added new FontAwesome library with Icon component (it's from @evilpeach )
  • Fixed zIndex on Copy Button container

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach August 14, 2020 08:48
@render
Copy link

render bot commented Aug 14, 2020

@pzshine pzshine changed the title 💄 Implemented bride code tab for OC index page. Scan: Implemented bride code tab for OC index page. Aug 14, 2020
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflict.

@pzshine pzshine changed the title Scan: Implemented bride code tab for OC index page. Scan: Implemented bridge code tab for OC index page. Aug 17, 2020
@pzshine pzshine merged commit 22f16a3 into master Aug 17, 2020
@pzshine pzshine deleted the oraclescript-bridge-code branch August 17, 2020 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp GuanYu - Implement Bridge Code (OS Index)
2 participants