Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: implement revamp header #2478

Merged
merged 4 commits into from
Aug 16, 2020
Merged

Scan: implement revamp header #2478

merged 4 commits into from
Aug 16, 2020

Conversation

evilpeach
Copy link
Contributor

@evilpeach evilpeach commented Aug 15, 2020

Fixed: #2417

Implementation details

  • Added custom button style on CssHelper
  • Added Icon.re to render font-awesome
  • Patched Navbar and Header aka TopBar
  • Removed unused image including connect and disconnect
  • Added CSS class named container.
  • Added Section and apply all pages.
  • Supported both desktop and mobile.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@evilpeach evilpeach requested a review from pzshine August 15, 2020 17:55
@render
Copy link

render bot commented Aug 15, 2020

@evilpeach evilpeach changed the title Scan: implement revamp header Scan: implement revamp header, navbar, profile Aug 15, 2020
@evilpeach evilpeach changed the title Scan: implement revamp header, navbar, profile Scan: implement revamp header Aug 16, 2020
scan/src/components/Header.re Outdated Show resolved Hide resolved
scan/src/components/Header.re Outdated Show resolved Hide resolved
scan/src/components/Header.re Outdated Show resolved Hide resolved
scan/src/components/NavBar.re Outdated Show resolved Hide resolved
scan/src/reusable/Section.re Outdated Show resolved Hide resolved
@evilpeach evilpeach requested a review from pzshine August 16, 2020 08:42
Copy link
Member

@pzshine pzshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evilpeach evilpeach merged commit 82e8014 into master Aug 16, 2020
@evilpeach evilpeach deleted the 2417-new-topbar branch August 16, 2020 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp GuanYu - Implement Narbar + Topbar + Account Modal
2 participants