Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: implement latest request on home page #2482

Merged
merged 5 commits into from
Aug 17, 2020
Merged

Conversation

evilpeach
Copy link
Contributor

@evilpeach evilpeach commented Aug 16, 2020

Fixed: #2419

Implementation details

  • Implemented latest request table
  • Replace unused RequestStatus by new one.
  • Implemented ID.toInt and use it.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@evilpeach evilpeach requested a review from pzshine August 16, 2020 18:41
@render
Copy link

render bot commented Aug 16, 2020

scan/src/pages/HomePage.re Outdated Show resolved Hide resolved
@evilpeach evilpeach requested a review from pzshine August 17, 2020 06:22
Copy link
Member

@pzshine pzshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evilpeach evilpeach merged commit 0a49d60 into master Aug 17, 2020
@evilpeach evilpeach deleted the 2419-latest-request branch August 17, 2020 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp GuanYu - Implement Latest Request (Home Page)
2 participants