Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Implemented make a request tab on OC index page #2485

Merged
merged 6 commits into from
Aug 20, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Aug 17, 2020

Fixed: #2424

Implementation details

  • Implemented make a request tab on OracleScript index page
    • Added new Client ID input with from_band default value.
    • Adjusted the result panel to be more proper.
    • Created a new connect panel.
    • Hid the tab on the mobile screen.
  • In order to min and ask count input, it will be depended on active validator count.
  • Updated AccountContext to have clientID, askCount, and minCount

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach August 17, 2020 07:38
@render
Copy link

render bot commented Aug 17, 2020

@pzshine pzshine force-pushed the make-new-request-tab-oc-index branch from 9ba9d4c to 5ee25dc Compare August 17, 2020 07:48
@pzshine pzshine force-pushed the make-new-request-tab-oc-index branch from d37c624 to b81c6ee Compare August 19, 2020 10:39
@pzshine pzshine requested a review from evilpeach August 19, 2020 12:11
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evilpeach evilpeach merged commit 7e18d91 into master Aug 20, 2020
@evilpeach evilpeach deleted the make-new-request-tab-oc-index branch August 20, 2020 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp GuanYu - Implement Make New Request (OS Index)
2 participants