Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Implemented OC index Top part, and patched padding bottom to section #2492

Merged
merged 4 commits into from
Aug 18, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Aug 17, 2020

Fixed: #2427

Implementation details

  • Implemented information box for OracleScript Index page
  • Added loading state to each tab
  • Changed default tab to requests instead of a make new request tab.
  • Fixed the CTooltip link issue
  • Patched paddingSmBottom zero to section on Datasource Index page

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach August 17, 2020 15:55
@render
Copy link

render bot commented Aug 17, 2020

Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's set the default tab to request
  2. On the mobile, the x-axis overflow.

scan/src/pages/OracleScriptIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/OracleScriptIndexPage.re Outdated Show resolved Hide resolved
@pzshine pzshine requested a review from evilpeach August 18, 2020 07:00
@pzshine pzshine merged commit 5f28b82 into master Aug 18, 2020
@pzshine pzshine deleted the oc-index-top-part branch August 18, 2020 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp GuanYu - Implement OS information (OS Index)
2 participants