Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Implemented validator index top part and uptimechart #2497

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Aug 19, 2020

Fixed: #2433
Fixed: #2436

Implementation details

  • Implemented a top part for the validator index page
  • Implemented Uptime Chart on the validator index page
  • Improved the CTooltip component to be more powerful.

Note:

  • Now, oracle reports and rank are mock data.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach August 19, 2020 10:14
@render
Copy link

render bot commented Aug 19, 2020

scan/src/pages/ValidatorIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/ValidatorIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/ValidatorIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/ValidatorIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/ValidatorIndexPage.re Outdated Show resolved Hide resolved
scan/src/subscriptions/ValidatorSub.re Outdated Show resolved Hide resolved
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's disable this link
    image
  2. Please fix it on 320px
    image

@pzshine pzshine requested a review from evilpeach August 20, 2020 04:30
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pzshine pzshine merged commit e3f9370 into master Aug 20, 2020
@pzshine pzshine deleted the validator-index-top-part branch August 20, 2020 05:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants