Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Implemented Delegators and ProposedBlock tabs #2500

Merged
merged 5 commits into from
Aug 20, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Aug 19, 2020

Fixed: #2438

Implementation details

  • Implemented tabs for Validator index page
    • Delegators tab
    • ProposedBlock tab

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach August 19, 2020 17:15
@render
Copy link

render bot commented Aug 19, 2020

Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We don't display the proposed block count for now because it will make a lot of load on database. So, let's remove it.
  2. Remove the pagination on the proposed blocks for both (Desktop and Mobile).

@pzshine pzshine requested a review from evilpeach August 20, 2020 03:14
@pzshine pzshine requested a review from evilpeach August 20, 2020 04:29
@pzshine pzshine merged commit 0ab6591 into master Aug 20, 2020
@pzshine pzshine deleted the delegators-proposedblock-tab-validator-index branch August 20, 2020 05:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp GuanYu - Implement Delegator, Proposed Block Table (Validator Index)
2 participants