Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: implement request index page top part #2501

Merged
merged 6 commits into from
Aug 21, 2020
Merged

Conversation

evilpeach
Copy link
Contributor

@evilpeach evilpeach commented Aug 20, 2020

Fixed: #2430
Fixed: #2431
Fixed: #2432

Implementation details

  • Request Info
  • reported validator chart
  • Calldata table
  • Result table
  • Proof
  • External Data
  • Support Mobile & Desktop

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@evilpeach evilpeach requested a review from pzshine August 20, 2020 04:46
@render
Copy link

render bot commented Aug 20, 2020

@pzshine
Copy link
Member

pzshine commented Aug 20, 2020

image

I just checked on mobile screen and found only one point is about buttons.

@evilpeach
Copy link
Contributor Author

evilpeach commented Aug 21, 2020

image

I just checked on mobile screen and found only one point is about buttons.

Do we change in this PR or make another PR for changing all button styles?

scan/src/pages/RequestIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/RequestIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/RequestIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/RequestIndexPage.re Outdated Show resolved Hide resolved
@pzshine pzshine merged commit 3a976bf into master Aug 21, 2020
@pzshine pzshine deleted the 2430-request-info branch August 21, 2020 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants