Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Implemented report chart and oracle data reports tab #2511

Merged
merged 5 commits into from
Aug 21, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Aug 21, 2020

Fixed: #2437
Fixed: #2439

Implementation details

  • Implemented Oracle Report Chart
  • Implemented Oracle Data Reports Tab

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach August 21, 2020 08:11
@render
Copy link

render bot commented Aug 21, 2020

@pzshine pzshine force-pushed the oc-report-chart-validator-index branch from 187e848 to 5781891 Compare August 21, 2020 08:36
scan/src/components/charts/OracleDataReportChart.re Outdated Show resolved Hide resolved
scan/src/components/charts/OracleDataReportChart.re Outdated Show resolved Hide resolved
scan/src/reusable/MobileCard.re Outdated Show resolved Hide resolved
@evilpeach evilpeach merged commit dc4218e into master Aug 21, 2020
@evilpeach evilpeach deleted the oc-report-chart-validator-index branch August 21, 2020 09:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants