Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: implement revamp guanyu on block home page #2560

Merged
merged 5 commits into from
Aug 25, 2020
Merged

Conversation

evilpeach
Copy link
Contributor

Fixed: #2536

Implementation details

  • Implement revamp Guan Yu on block home page
  • remove minHeight on Row
  • remove Styles.loadingBox then add fullWidth props to LoadingCensorBar instead.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@evilpeach evilpeach requested a review from pzshine August 25, 2020 09:21
@render
Copy link

render bot commented Aug 25, 2020

@evilpeach evilpeach requested a review from pzshine August 25, 2020 12:33
@evilpeach evilpeach merged commit 2d65582 into master Aug 25, 2020
@evilpeach evilpeach deleted the 2536-revamp-blocks branch August 25, 2020 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guanyu revamp - Block Home Page & Block Index Page
2 participants