Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Remove redundant emptyContainer styles #2713

Merged
merged 9 commits into from
Oct 6, 2020

Conversation

Pitchanai
Copy link
Contributor

@Pitchanai Pitchanai commented Oct 5, 2020

Fixed: #2614

Implementation details

  • Remove redundant emptyContainer styles

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@render
Copy link

render bot commented Oct 5, 2020

CHANGELOG_UNRELEASED.md Outdated Show resolved Hide resolved
CHANGELOG_UNRELEASED.md Outdated Show resolved Hide resolved
CHANGELOG_UNRELEASED.md Outdated Show resolved Hide resolved
scan/src/components/TotalRequestsGraph.re Outdated Show resolved Hide resolved
scan/src/components/HistoricalBondedGraph.re Outdated Show resolved Hide resolved
scan/src/reusable/EmptyContainer.re Outdated Show resolved Hide resolved
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @pzshine Please review this.

Copy link
Member

@pzshine pzshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@evilpeach evilpeach merged commit 41f0a13 into master Oct 6, 2020
@evilpeach evilpeach deleted the remove-redundant-emptycontainer branch October 6, 2020 04:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant empty container styles
3 participants