This repository has been archived by the owner on Nov 16, 2022. It is now read-only.
chain: Add price_symbols endpoint
#2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebevrishot
changed the title
price_symbols endpointprice_symbols endpoint
thebevrishot
changed the title
price_symbols endpointprice_symbols endpoint
taobun
suggested changes
Nov 4, 2020
chain/hooks/price/price.go
Outdated
| it := h.db.NewIterator(nil, nil) | ||
| it.Seek(prefix) | ||
|
|
||
| prices := []Price{} |
There was a problem hiding this comment.
change to return a list of string.
chain/hooks/price/price.go
Outdated
|
|
||
| prices := []Price{} | ||
| for ; it.Valid() && bytes.HasPrefix(it.Key(), prefix); it.Next() { | ||
| var p Price |
There was a problem hiding this comment.
append str(it.Key()[len(prefix):])
chain/x/oracle/client/rest/query.go
Outdated
|
|
||
| bz, height, err := cliCtx.Query(fmt.Sprintf("band/price_symbols/%s/%s", r.FormValue("ask_count"), r.FormValue("min_count"))) | ||
|
|
||
| prices := []price.Price{} |
taobun
approved these changes
Nov 5, 2020
| minCount := common.Atoui(paths[3]) | ||
|
|
||
| prefix := []byte(fmt.Sprintf("%d,%d,", askCount, minCount)) | ||
| it := h.db.NewIterator(util.BytesPrefix(prefix), nil) |
taobun
suggested changes
Nov 5, 2020
chain/x/oracle/client/rest/query.go
Outdated
|
|
||
| bz, height, err := cliCtx.Query(fmt.Sprintf("band/price_symbols/%s/%s", r.FormValue("ask_count"), r.FormValue("min_count"))) | ||
|
|
||
| symbols := []string{} |
There was a problem hiding this comment.
Using var symbols []string (Reduce unnecessarily allocate)
taobun
approved these changes
Nov 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #2812
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)