Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Bandchain.js: Implemented getRequestIDByTxHash fn on client module #2915

Merged
merged 4 commits into from
Nov 21, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Nov 19, 2020

Fixed: #2914

Implementation details

  • Implemented getRequestIDByTxHash on client module
  • Wrote the test cases
    • 1 Request msg case
    • Multi request msg case
    • no request msg case

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@render
Copy link

render bot commented Nov 19, 2020

@pzshine pzshine merged commit b59f57b into master Nov 21, 2020
@pzshine pzshine deleted the bandchainjs-get-request-id-by-tx-hash branch November 21, 2020 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement getRequestIDByTxHash on client module
2 participants