Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log workaround #5

Merged
merged 2 commits into from Feb 12, 2018
Merged

Log workaround #5

merged 2 commits into from Feb 12, 2018

Conversation

nhuray
Copy link
Contributor

@nhuray nhuray commented Feb 12, 2018 •
edited

Hi guys,

Here is a PR to implement the log workaround for PHP-FPM images.
Please read those issues for more details:

I also added a default php.ini in the images and added tests.

Nik

PS: I tested this image with our project

@nhuray nhuray self-assigned this Feb 12, 2018
bratislavml
bratislavml approved these changes Feb 12, 2018
View reviewed changes
Copy link

@bratislavml bratislavml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bit-deploy
bit-deploy approved these changes Feb 12, 2018
View reviewed changes
Copy link

@bit-deploy bit-deploy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nhuray nhuray merged commit 0fc9f1c into master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bit-deploy bit-deploy bit-deploy approved these changes

@bratislavml bratislavml bratislavml approved these changes

@msotoperdomo msotoperdomo Awaiting requested review from msotoperdomo

Assignees

@nhuray nhuray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nhuray @bit-deploy @bratislavml