Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to rasterio #154

Merged
merged 4 commits into from Jun 3, 2023
Merged

Switch to rasterio #154

merged 4 commits into from Jun 3, 2023

Conversation

banesullivan
Copy link
Owner

With the addition of the new rasterio based source module in large-image, I have decided to go all in on rasterio here and drop GDAL use. Additionally, I have decided to limit the scope of this project to only geospatial images moving forward (since large-image has development underway for better non-geo visualization in Jupyter).

This is a start to a handful of changes that will ultimately make localtileserver easier to use and more performant.

With this switch to rasterio and some significant internal refactoring, this will warrant a major version bump -- v1.0.0 is on its way

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2023

Codecov Report

Merging #154 (7eeedab) into main (d5bfa56) will increase coverage by 1.27%.
The diff coverage is 88.88%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   85.66%   86.93%   +1.27%     
==========================================
  Files          24       24              
  Lines        1381     1370      -11     
==========================================
+ Hits         1183     1191       +8     
+ Misses        198      179      -19     

@banesullivan banesullivan marked this pull request as ready for review June 3, 2023 16:14
@banesullivan
Copy link
Owner Author

cc @giswqs, I think you'll be happy to see this! But this PR is completely changing the dependency stack and may impact your usage

@giswqs
Copy link

giswqs commented Jun 3, 2023

This is great. It will make the installation much easier. I will keep an eye on this and make changes downstream accordingly

@banesullivan
Copy link
Owner Author

Going ahead with a merge as I'd like to do some other internal refactoring. Release is not coming immediately as I need to do more testing and want feedback from @giswqs

@banesullivan banesullivan merged commit b08d2da into main Jun 3, 2023
7 checks passed
@banesullivan banesullivan deleted the feat/rasterio branch June 3, 2023 16:20
@giswqs
Copy link

giswqs commented Jun 3, 2023

Sure. I can help with testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants