Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for #75: File system seg fault on Windows #76

Merged
merged 2 commits into from
Dec 25, 2021
Merged

Conversation

banesullivan
Copy link
Owner

@banesullivan banesullivan commented Dec 23, 2021

I went ahead and just skipped this for Windows altogether, what do you think, @Huite and @akaszynski?

Resolves #75, resolves pyvista/pyvista#1961

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #76 (3c80051) into main (5f534e2) will increase coverage by 0.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   86.50%   87.05%   +0.55%     
==========================================
  Files           4        4              
  Lines         363      363              
==========================================
+ Hits          314      316       +2     
+ Misses         49       47       -2     

@akaszynski
Copy link
Collaborator

Agreed, especially considering the severity of this bug.

@banesullivan
Copy link
Owner Author

Did a little refactor too

@akaszynski
Copy link
Collaborator

Looks good.

@banesullivan
Copy link
Owner Author

Before I merge and release, @Huite, do you think you'll have a chance to double check this on your system that experiences the seg fault?

@Huite
Copy link

Huite commented Dec 24, 2021

I don't think I can -- I won't be at the office for the next two weeks, and unfortunately I'm unable to reproduce it at home (fiddled with several USB, but to no avail). So January 11th is likely the first opportunity I'd get to test.

(Changes look good to me.)

@banesullivan
Copy link
Owner Author

Okay, thanks for letting me know. I'll go ahead within merging and releasing as this should simply disable the feature for Windows altogether. we can always update later to optionally enable on windows

@banesullivan banesullivan merged commit 43614af into main Dec 25, 2021
@Huite
Copy link

Huite commented Jan 11, 2022

Back at the office, I just tested it: the fix works, I was segfaulting on 0.5.10 and pip install scooby=0.5.11 fixes it.

@banesullivan banesullivan deleted the win-filesystem branch March 1, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants