-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch for #75: File system seg fault on Windows #76
Conversation
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 86.50% 87.05% +0.55%
==========================================
Files 4 4
Lines 363 363
==========================================
+ Hits 314 316 +2
+ Misses 49 47 -2 |
Agreed, especially considering the severity of this bug. |
Did a little refactor too |
Looks good. |
Before I merge and release, @Huite, do you think you'll have a chance to double check this on your system that experiences the seg fault? |
I don't think I can -- I won't be at the office for the next two weeks, and unfortunately I'm unable to reproduce it at home (fiddled with several USB, but to no avail). So January 11th is likely the first opportunity I'd get to test. (Changes look good to me.) |
Okay, thanks for letting me know. I'll go ahead within merging and releasing as this should simply disable the feature for Windows altogether. we can always update later to optionally enable on windows |
Back at the office, I just tested it: the fix works, I was segfaulting on 0.5.10 and |
I went ahead and just skipped this for Windows altogether, what do you think, @Huite and @akaszynski?
Resolves #75, resolves pyvista/pyvista#1961