Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lens dependency #39

Merged
merged 5 commits into from Jul 29, 2015
Merged

Remove lens dependency #39

merged 5 commits into from Jul 29, 2015

Commits on Jul 29, 2015

  1. Remove lens dependency 

    - Added a bunch of explicit type definitions
- Added explicit exports for a few modules
- Fixed imports
- Fixed unused variables
- Lint. Fixed most of record type definitions
- No more compiler warnings at this stage
- Removed dead code. Can always get it back from git
    @jaseemabid
    jaseemabid committed Jul 29, 2015
    Copy the full SHA
    344c5b6 View commit details
    Browse the repository at this point in the history

  2. Fix a bunch of lint errors (hlint)

    @jaseemabid
    jaseemabid committed Jul 29, 2015
    Copy the full SHA
    6b53516 View commit details
    Browse the repository at this point in the history

  3. Import <$> from Data.Functor explicitly 

    This will cause a warning in 7.10 as <$> is already part of prelude.
Never mind!
    @jaseemabid
    jaseemabid committed Jul 29, 2015
    Copy the full SHA
    1e83942 View commit details
    Browse the repository at this point in the history

  4. Add <$> to Bencode.hs

    @jaseemabid
    jaseemabid committed Jul 29, 2015
    Copy the full SHA
    859d007 View commit details
    Browse the repository at this point in the history

  5. import <* from Control.Applicative for Bencode 

    This will also cause a warning in 7.10 like <$>
    @jaseemabid
    jaseemabid committed Jul 29, 2015
    Copy the full SHA
    33e41c6 View commit details
    Browse the repository at this point in the history