Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitenberg: Add sample block #7

Merged
merged 7 commits into from May 28, 2023
Merged

Gitenberg: Add sample block #7

merged 7 commits into from May 28, 2023

Conversation

bangank36
Copy link
Owner

@bangank36 bangank36 commented May 27, 2023 •
edited

Summary

  • Insert sample block into blocks-library: port the submit button from cf7-blocks repo

Reference

Testing

  • Confirm the creation of the shields badge block
image

@bangank36 bangank36 added the enhancement New feature or request label May 27, 2023
@bangank36 bangank36 self-assigned this May 27, 2023
bangank36
bangank36 commented May 28, 2023
View reviewed changes
Copy link
Owner Author

@bangank36 bangank36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge, with some side notes:

  • How to parse the generated badge image into Shields badge block, so far the block is saved as raw image tag ( nit: try to use img[src*='shields.io'] )
  • Intercept rawHTML method somehow?

@bangank36 bangank36 merged commit d37c042 into trunk May 28, 2023
@bangank36 bangank36 mentioned this pull request May 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bangank36 bangank36

Labels
enhancement New feature or request
Projects
Personal Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bangank36