Add 2016 recordings #69
Conversation
|
Maybe @ertyseidohl will have more feedback, but this approach sounds reasonable to me! I say carry on. 👍 |
The 2015 talk transcripts are named after the author slugs, but the 2014 talks do not. This leads to a minor difference in the construction of the transcript links. To support extracting the recording page JavaScript into a separate, shared file, update the 2015 talk data to include the (partial) filename of the transcript.
Continue to unify the 2014 and 2015 JavaScript by moving the message for missing videos from code into data.
Now that the only difference between 2015 and 2016 is the transcript links, make that a paramater that each passes in.
|
Okay, refactoring done! Tomorrow I'll add the 2016 data. |
Issue bangbangcon#68 Add 2016 recordings page
Don't show a link if the `authorslug` is set to `false`.
Issue bangbangcon#68 Add 2016 recordings page
Also markdown-ize the other quick links.
|
@lkuper @ertyseidohl I think this is ready to merge! It got... kinda big, but I tried to keep the individual commits easily reviewable. |
|
I have it up on my fork, if you want to see the end result: https://jasonaowen.github.io/bangbangcon.github.io/2016/ . The only change in that branch that's not in this PR is deleting the To test, I checked that I could see the embedded video for each talk, and that the link from the speaker to the speakers page worked correctly. Thank you for making sure all the talks in the program are present and in order in the YouTube playlist - that made it much easier for me to double-check that I'd gotten all the talks! |
|
👍 |
|
I'll go ahead and merge if nobody has any objections |
|
Looks good to me too! Thanks @jasonaowen. |
|
@ertyseidohl are you going to merge this? |
|
Whoops - didn't get a notif! Sorry @lkuper @jasonaowen -- merging. |
Update the 2016 recordings page to show the videos in the YouTube playlist!
After looking through the 2014 and 2015 recordings pages, they seem to have some very similar (but not identical) JavaScript. So, here's my plan:
Resolves #68 add 2016 recordings page