Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributing guide #26

Merged
merged 5 commits into from
Feb 14, 2022
Merged

Conversation

Ayase-252
Copy link
Contributor

@Ayase-252 Ayase-252 commented Jan 18, 2022

仿照 nodejs/nodejs.dev 那边的做法写了个贡献指南。

为了防止 PR 长时间没人 review,也仿照 nodejs/nodejs.dev 组的做法,添加了个自愿申请 Collaborator 的程序,看看可不可行? 👀

@Ayase-252 Ayase-252 requested a review from trim21 January 18, 2022 14:56
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #26 (153f4e9) into master (d7e0cc5) will increase coverage by 1.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   87.06%   88.72%   +1.65%     
==========================================
  Files           5        7       +2     
  Lines         116      133      +17     
  Branches        7        8       +1     
==========================================
+ Hits          101      118      +17     
  Misses         14       14              
  Partials        1        1              
Impacted Files Coverage Δ
packages/design/index.tsx 100.00% <0.00%> (ø)
packages/design/components/Typography/Link.tsx 100.00% <0.00%> (ø)
packages/design/components/Typography/index.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e0cc5...153f4e9. Read the comment docs.

@github-actions
Copy link
Contributor

preview url: https://pr-26--bangumi-next.netlify.app

@trim21
Copy link
Contributor

trim21 commented Jan 18, 2022

看看

@trim21
Copy link
Contributor

trim21 commented Jan 18, 2022

这种纯 markdowon PR 是不是应该 skip build?

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Ayase-252
Copy link
Contributor Author

可以 skip build

@trim21
Copy link
Contributor

trim21 commented Feb 14, 2022

话说这个不合吗

@Ayase-252 Ayase-252 merged commit e05aa72 into bangumi:master Feb 14, 2022
@trim21
Copy link
Contributor

trim21 commented Feb 14, 2022

这个fork的链接还是错的…

@Ayase-252 Ayase-252 deleted the docs/contribution branch February 14, 2022 15:12
@Ayase-252
Copy link
Contributor Author

这个fork的链接还是错的…

啊,太久没看没注意...找个时间修吧,文档大概意思还是对的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants