-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename gem to rubyvm-debug_inspector #18
Comments
Regarding: http://guides.rubygems.org/name-your-gem/ GEM NAME: Is this wrong for the naming rule?
Are there any other cases, for below status, and the name is
|
Ah sorry, you are right. Main class or module is |
I only find one case that the pattern is used as a reference. |
I agree it probably makes sense but i think this is water under the bridge at this point, as there's a fair number of gems relying on this one already and it would disrupt things too much. We should just consider the bad name 'historical baggage' :P |
I agree. Changing the gem name at least now confusing users. Recently I experienced same kind of situation about renaming gem in another project. Ref:
|
It's not just the gem name (we can keep the gem name), I don't think constants like this
'DebugInspector' exists only to add ::VERSION constant. It's not living in the same namespace as the implementation. This is odd. So I think we could modify #19 to keep the gem name "debug_inspector", but require_relative "rubyvm/debug_inspector" With RubyVM::DebugInspector (in C), and RubyVM::DebugInspector::VERSION (in Ruby), and no DebugInspector constant.I t's not backwards compatible, but is DebugInspector::VERSION even a feature? And updating to RubyVM::DebugInspector::VERSION isn't hard. Plus current gem is 0.0.3, so you're allowed to break things. |
That's better. It makes identifying & finding extensions to the RubyVM easy, but unfortunately debug_inspector isn't part of that. |
@R-obert sounds fine to me! Thanks! 👍 |
Closed in favor of the PR. Thanks @R-obert |
Shouldn't gem name be rubyvm-debug_inspector?
And,
mv lib/debug_inspector.rb lib/rubyvm/debug_inspector.rb
, so:The text was updated successfully, but these errors were encountered: